Envman functions #819
Merged
Envman functions #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
godrei
force-pushed
the
envman-functions
branch
from
f1036b4
to
104e42a
Compare
ofalvai
reviewed
Oct 7, 2022
| cmd.SetTimeout(timeout) | ||
| cmd.SetHangTimeout(noOutputTimeout) | ||
| cmd.SetStandardIO(inReader, outWriter, errWriter) | ||
| cmd.AppendEnv("PWD=" + workDirPth) | ||
| cmd.SetEnv(append(envs, "PWD="+workDirPth)) |
There was a problem hiding this comment.
Why is this better than the existing AppendEnv() call?
There was a problem hiding this comment.
AppendEnv is working with a single environment variable + checking if the command has Env set or not is unnecessary because it will always be nil, and the envs we set already contain the os.Environ.
Although we don't need both functions, so I removed cmd.AppendEnv in 73afe9d
tothszabi
reviewed
Oct 10, 2022
tothszabi
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MINOR version update
Context
This PR makes Bitrise CLI use envman functionalities through exported functions rather than through envman binary calls.
Changes
tools.Envman<Function>sto use envman exported functions.Investigation details
Decisions